This topic came up in a patch submission, and it occurred to me that we
never actually wrote down canonical limits in the wiki. So I went ahead and
added the proposed limits here:
It seems that we never really decided on 112-characters vs. 120-characters,
so I wrote down 112-characters for now. At least most were satisfied with
an 80-column "soft" limit and an exception to the limits for tables...
On Sun, May 6, 2012 at 7:10 AM Uwe Hermann <uwe(a)hermann-uwe.de> wrote:
On Sun, May 06, 2012 at 02:12:32PM +0200, Carl-Daniel
Unless someone protests, I'd say 112 columns
are the new absolute hard
limit, and there is no exception for anything except tables.
Table compression (i.e. having a few rows with unaligned elements
following a super-long element) is good as long as the majority of
elements in each column are aligned.
Those limits only affect new code for the next 2 months starting today,
and if we're still happy with the limit after 2 months, the rest of the
code will be changed gradually where it helps readability.
Should we encounter code within the next 2 months where 112 columns are
way worse than 120, the limit will be increased to 120 with no
additional evaluation time period.
I for one would very much prefer the 79/80 character (soft) limit per
No objections about breaking the rule for exception cases where this
makes sense (large tables, long lines which cannot be split nicely for
whatever reasons), but as a general guideline sticking to 79 char/line
is a very good thing IMHO.
flashrom mailing list