Hi guys, sorry for the delay again!

TL;DR: I did "make clean CONFIG_INTERNAL=no" and it looks like it built successfully! Here's the email as I assembled it before doing the "make clean":

===

root@chrx:/home/chrx/Github/flashrom# git describe
v0.9.9-86-ge1a960e

=== 

I've attached the output files you asked for to this message.

I did not change the code at all and I pulled from the master branch here IIRC: https://github.com/flashrom/flashrom

I tried to build using "make CONFIG_INTERNAL=no" early on but this was the error output:

===

cli_classic.o: In function `main':
cli_classic.c:(.text.startup+0xaac): undefined reference to `force_boardmismatch'
print.o: In function `print_supported_boards_helper':
print.c:(.text+0x245): undefined reference to `board_matches'
print.o: In function `print_supported':
print.c:(.text+0xf11): undefined reference to `chipset_enables'
print.c:(.text+0xff3): undefined reference to `chipset_enables'
spi.o: In function `spi_get_valid_read_addr':
spi.c:(.text+0x12c): undefined reference to `ichspi_bbar'
collect2: error: ld returned 1 exit status
Makefile:1018: recipe for target 'flashrom' failed
make: *** [flashrom] Error 1

===

Everything above that in the build process looked ok!


--
Anders Nelson

+1 (517) 775-6129

www.erogear.com

On Sat, Nov 4, 2017 at 11:21 AM, Nico Huber <nico.h@gmx.de> wrote:
Hi Anders,

On 03.11.2017 21:35, Anders Nelson wrote:
> Hi guys,
>
> Here's the error I get trying to apply the patch:
>
> "root@chrx:/home/chrx/Github/flashrom# git apply --check
> /home/chrx/Downloads/ich_descriptors-amd64.patch
> error: patch failed: ich_descriptors.c:1064
> error: ich_descriptors.c: patch does not apply"

sorry, I was looking at the wrong version of the code. Doesn't matter,
see below.

>
> Derp? Here's my output from "cc -v":
>
> ...
>
> And here's the output from the second command you asked for:
>
> "root@chrx:/home/chrx/Github/flashrom# cc -dM -E - < /dev/null
> ...
> #define __x86_64__ 1
> ...
> #define __amd64__ 1
> ...

Both are there that's fine. And I think now, that my original assumption
that this could be an issue was wrong: We do check for x86 not only in
the Makefile but also in ichspi.c too (pretty weird redundancy) and the
latter check is in sync with ich_descriptors.c.

I've also tried to build flashrom on Ubuntu 16.04 with the same compiler
version... and it worked *shrug*.

>
> Whaaatsa goin' onnn? Thanks for your help!

No clue, actually. Did you already try to build with `make
CONFIG_INTERNAL=no`? Just want to know, that this doesn't stall
your work. We are ofc very interested to understand and fix the
actual problem.

Can you please send us a copy of the `ichspi.o` and `ich_descriptors.o`
of the failing build.

Did you change anything in the code? or tried to build different
versions? switch branches? in case, you could try a `make clean`
(although, I can't imagine why it would be necessary).

Oh, I nearly forgot: Please show us the output of `git describe` (I'm
loosing track of our branches atm).

Nico