Re: [flashrom] [PATCH] Revamp board-specific quirk handling, laptop support

[Carl-Daniel Hailfinger]

Am 04.03.2011 03:11 schrieb Carl-Daniel Hailfinger:
> Currently flashrom runs all board-specific quirks after laptop detection
> is done. This means there is no way to reflash a laptop without using
> the programmer parameter laptop=force_I_want_a_brick.
>
> Handle board-specific quirks in three phases:
> Before Super I/O probing (e.g. blacklisting of some Super I/O probes,
>
> or unhiding the Super I/O)
> 2. Before the laptop enforcement decision (e.g. whitelisting a laptop
> for flashing)
> 3. After chipset enabling (all current board enables)
>
> Implementation note: All entries in board_pciid_enables get an
> additional phase parameter.
>
> With this patch, it should be possible to whitelist supported laptops
> with a matching entry (phase P2) in board_pciid_enables which points to
> a function setting laptop_ok=1. (In case DMI is broken, matching might
> be a little bit more difficult, but it is still doable.)
>
> Signed-off-by: Carl-Daniel Hailfinger
> {0x10DE, 0x0547, 0x147B, 0x1C2F,  0x10DE, 0x0548, 0x147B, 0x1C2F, NULL,          NULL,         NULL,          "abit",        "AN-M2",                 0,   P3, NT, nvidia_mcp_gpio2_raise},

With feedback from Michael Karcher on IRC the ordering was changed slightly.

Thanks for the review on IRC!
Acked-by: Michael Karcher

and committed in r1294.

Regards,
Carl-Daniel