Re: [flashrom] [PATCH] Add Baytrail & Rangeley/Avoton support

[Stefan Tauner]

On Fri, 30 May 2014 15:13:49 -0600
Martin Roth  wrote:
> /* Enable BIOS writing */
> old = mmio_readl(ilb + 0x1c);

There are (or were) quite some unclear bits in this patch, but the line
above is the most puzzling. Why is BC in the memmapped ILB region used
instead of BCR at SPIBAR (SBASE) + 0xFC? The latter seems to be more
similar to the old BIOS_CNTL and does contain the infamous SMM bit #5
that we try to unset for previous generations. The lock and write
enable bits seem to be mirrored though.