Okay, so I applied the same changes to the W25x16 and got good results. It looks like the same applies to the W25x{16,32,64} products in addition to the W25x{10,20,40,80}. Please update the patch to include the additional chips.

W25x{16,32,64} datasheet: http://www.winbond-usa.com/products/Nexflash/pdfs/datasheets/W25X16_32_64h.pdf

On Thu, Feb 11, 2010 at 3:56 PM, David Hendricks <dhendrix@google.com> wrote:

D'oh! I just realized that this patch doesn't affect the x16. I really ought to read the patch more carefully...

On Thu, Feb 11, 2010 at 3:50 PM, David Hendricks <dhendrix@google.com> wrote:

On Sun, Jan 31, 2010 at 6:31 PM, Sean Nelson <audiohacked@gmail.com> wrote:

Fix erase blocks for Winbond W25X* SPI chips. The Winbond W25X10 and related chips only have 4k and 64k blocks and only accept erase commands: 20h, d8h, and c7h.

Signed-off-by: Sean Nelson <audiohacked@gmail.com>

Tested on a W25x16 flash chip using an NM10 southbridge. Verbose flashrom -E log attached. Following an erase with a read, the image produced turns up all 0xFF bytes. The warnings reported seem benign, and probably have more to do with the NM10 than the flash chip...

Acked by: David Hendricks <dhendrix@google.com>

--
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.

--
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.

--
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.