On Fri, Apr 27, 2012 at 7:56 AM, Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de> wrote:
On Fri, 2012-04-27 at 01:45 +0200, Stefan Tauner wrote:
> > ... so I started looking around and found the fix : I added #include
> > <linux/types.h> before #include <linux/spi/spidev.h>, line 27 of
> > flashrom-0.9.5.2/linux_spi.c
> >
> > It now compiles and works.
>
> afaics this should not be necessary at all.
> the header in http://packages.slackverse.org/?v=3&p=316 includes
> linux/types.h itself at the top (as expected). can you explain why
> yours does not?

Old kernel headers. We already fixed that incompatibility in r1517,
which is shortly after 0.9.5.2

Oh my...

% ls -l /usr/include/linux/spi/spidev.h
-rw-r--r-- 1 root root 4595 Nov 14  2008 /usr/include/linux/spi/spidev.h

2008 !?! You are absolutely right.

% grep LINUX_VERSION_CODE /usr/include/linux/version.h
#define LINUX_VERSION_CODE 132635

That's version 2.6.27 !
I'll have a look around.

Thanks for guessing my issue, and thanks for the fix "maybe superfluous but just in case".
And thanks for the explanation about the motherboard ;-)

Sincerely,
  =^.^=