Change in flashrom[master]: ft2232_spi.c: Refactor singleton states into reentrant pattern - flashrom-gerrit

12 Apr 2021


      Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52256 )
Change subject: ft2232_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 2:
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/52256/comment/943548a1_d60af018 
PS1, Line 626: spi_data->ftdic_context = ftdic;
...
Done
Hmmm, memcpy() isn't necessary to copy structs by value. See comments on latest patchset.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I67518a58b4f35e0edaf06ac09c9374bdf06db0df
Gerrit-Change-Number: 52256
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 12 Apr 2021 08:32:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment