Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops - flashrom-gerrit

27 Sep 2017


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/21702 )
Change subject: nicintel_eeprom: Move variable declarations out of loops
......................................................................
Patch Set 1:
I actually looked in the codebase for other variable declarations in for heads and didn't see any. Perhaps there are some that you know of? In any case, if we don't want to support non-c99 then we should make that explicit in the Makefile.
I suspect that this bug/error was only triggered by a recent patch, which worked fine with Jenkins and a couple other versions of GCC. This patch is just a quick fix, which will work no matter if we force C99 compatibility or not.
Here's build_details.txt: https://paste.flashrom.org/view.php?id=3052
-- 
To view, visit https://review.coreboot.org/21702
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31
Gerrit-Change-Number: 21702
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Sep 2017 05:59:08 +0000
Gerrit-HasComments: No