Change in flashrom[master]: flashrom: Mark RISCV as non memory-mapped I/O architecture

Attention is currently required from: Khem Raj, Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51960 ) Change subject: flashrom: Mark RISCV as non memory-mapped I/O architecture ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: What's the reason for the change? I don't even understand why the Makefile enables the programmers for the other arches w/o port-I/O implementation. File Makefile: https://review.coreboot.org/c/flashrom/+/51960/comment/86a650df_d42790ca PS1, Line 562: ifneq ($(ARCH),$(filter $(ARCH),x86 mips ppc arm sparc arc riscv)) Is this really what you want? Note the `ifneq`, it means the programmers below would be enabled for riscv. -- To view, visit https://review.coreboot.org/c/flashrom/+/51960 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I55c4e8529d36f0850dd56441c3fb8602c5d889fd Gerrit-Change-Number: 51960 Gerrit-PatchSet: 1 Gerrit-Owner: Khem Raj Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Khem Raj Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Comment-Date: Tue, 30 Mar 2021 23:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
Nico Huber (Code Review)