Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Sergii Dmytruk. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 22: (1 comment) File ite_ecfw.c: https://review.coreboot.org/c/flashrom/+/55715/comment/87db202f_5479b0cc PS20, Line 332: if (blocks_1_2) { : itestring->flags.clock_source = CLOCK_SOURCE_INTERNAL; :
The question is if we remove it will not break things? Maybe, maybe not :S Let's keep it for now but add a comment
-- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 22 Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Felix Singer <felixsinger@posteo.net> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 18:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de> Gerrit-MessageType: comment
participants (1)
-
Michael Niewöhner (Code Review)