[M] Change in flashrom[main]: erasure_layout: Add an option to sacrifice unchanged blocks for speed

[Bill XIE (Code Review)]

Attention is currently required from: Aarya, Anastasia Klimchuk.

Bill XIE has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email )

Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed
......................................................................


Patch Set 6:

(4 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/84721/comment/2dad0d57_7381a63c?usp... :
PS5, Line 9: Someone may prefer to sacrifice sub-blocks needless to change within a
           : larger erase block for programming speed. These people who are okay to
           : fry their chip sooner can set this option. If the percentage of
           : sub-blocks needless to change within a larger erase block is lower
           : than the given value, the whole larger erase block will be erased.
> I wrote another version of commit message, what do you think? I can  update myself, but first I want […]
> Done

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/84721/comment/4bc97cd3_5669fe6f?usp... :
PS3, Line 124: 	       "      --sacrifice-ratio <ratio>     The percentage of overall sub-blocks needless to\n"
             : 	       "                                    change within a larger erase block to be sacrificed\n"
             : 	       "                                    for programming speed, default 0, max 100\n"
> I have an idea, what do you think: […]
> Done and added context for "S+1 size block".

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/84721/comment/fcde11ad_97a2a612?usp... :
PS5, Line 126: max 100
> What do you think about restricting max to 50? I don't think values more than 50 make sense.
> Done

https://review.coreboot.org/c/flashrom/+/84721/comment/68789828_8c24791e?usp... :
PS5, Line 1141: Invalid input of sacrifice ratio, use default 0
> Invalid input of sacrifice ratio, valid range is 0-50. Fallback to default value 0. […]
> Done