[L] Change in flashrom[main]: rpmc: add rpmc commands feature

[Peter Marheine (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Matti Finder.

Peter Marheine has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email )

Change subject: rpmc: add rpmc commands feature
......................................................................


Patch Set 1:

(1 comment)

File include/rpmc.h:

https://review.coreboot.org/c/flashrom/+/84934/comment/38966ef0_ec9b0810?usp... :
PS1, Line 37: 	uint8_t status;
It looks like you use status values in the CLI and 0x80 always indicates success, but that's not a value I would expect to indicate success. Can you add a little documentation here and perhaps also explain better what the function return values mean (even if it's just referring to an explanation attached to this field)?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84934?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38
Gerrit-Change-Number: 84934
Gerrit-PatchSet: 1
Gerrit-Owner: Matti Finder <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Matti Finder <[e-mail]>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No