Nico Huber has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/19206/1/util/git-hooks/pre-push File util/git-hooks/pre-push:
Line 41: else Why put an else here if we exited anyway?
PS1, Line 63: pusing *pushing
PS1, Line 57: # Make _really_ sure we do not rewrite precious history : for lbranch in "${precious_branches[@]}"; do : if [ "$remote_ref" = "refs/heads/$lbranch" ]; then : nonreachable=$(git rev-list $remote_sha ^$local_sha) : if [ -n "$nonreachable" ]; then : echo "Only fast-forward pushes are allowed on $lbranch." >&2 : echo "$nonreachable is not included in $remote_sha while pusing to $remote_ref" >&2 : exit 1 : fi : fi : done
Isn't this configurable in the upstream repo?
The code looks good, I was just worried that we reinvent the wheel. There is the "receive.denyNonFastForwards" option that does the same but for all branches. OTOH, will we have anything but precious bran- ches with creation of new branches being forbidden?