[S] Change in flashrom[main]: Makefile,meson.build: Add support for Sphinx versions prior to 4.x

[Anton Samsonov (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Peter Marheine, Thomas Heijligen.

Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77778?usp=email )

Change subject: Makefile,meson.build: Add support for Sphinx versions prior to 4.x
......................................................................


Patch Set 6:

(3 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/77778/comment/0a8fb8eb_d3f23d71 :
PS3, Line 7: 3
> Oh I see! Maybe you can rename the title as  […]
> Acknowledged

File doc/sphinx-wrapper.sh:

https://review.coreboot.org/c/flashrom/+/77778/comment/95a8f73a_86adf847 :
PS5, Line 8: "$@"
> `$@` means all the command-line parameters, but the parameters needed for this invocation are starting from $5 and until the end?

Yes, `$@` means all the parameters [that are still left]. The script's self path, (denoted by 'sphinx_wrapper' in meson.build), is `$0`. Then there are 2 additional parameters we capture as 'OUTPUT_HOME' and 'MAN_OUTPUTS' in the script, and then `sphinx-build` full path (denoted by 'sphinx' in meson.build), — all 3 are cut from `$@` by `shift 3`, so that only arguments for `sphinx-build` are left.


https://review.coreboot.org/c/flashrom/+/77778/comment/b11042fc_95c948aa :
PS5, Line 14:
> I know this info is in commit message…

I thought this was self-explanatory from `[ "${SPHINXBUILD_MAJOR}" -ge 4 ]`, but you are right in that there is no such thing as a over-commenting. OK, I'll add it a bit later.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/77778?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b
Gerrit-Change-Number: 77778
Gerrit-PatchSet: 6
Gerrit-Owner: Anton Samsonov <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Anton Samsonov <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-Attention: Thomas Heijligen <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Anton Samsonov <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Comment-Date: Sat, 27 Jan 2024 09:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anton Samsonov <[e-mail]>
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Gerrit-MessageType: comment