Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured

[Lubomir Rintel (Code Review)]

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/22263


Change subject: vt_vx: check whether the chipset's MMIO range is configured
......................................................................

vt_vx: check whether the chipset's MMIO range is configured

Avoid attempting to read the SPI bases from the location 0x00000000, all
zeroes mean that the chipset's MMIO area is not enabled.

Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293
---
M chipset_enable.c
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/22263/1

diff --git a/chipset_enable.c b/chipset_enable.c
index 3437792..d8b579c 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -1013,10 +1013,18 @@
 	switch(dev->device_id) {
 		case 0x8353: /* VX800/VX820 */
 			spi0_mm_base = pci_read_long(dev, 0xbc) << 8;
+			if (spi0_mm_base == 0x0) {
+				msg_pdbg ("MMIO not enabled!\n");
+				return ERROR_FATAL;
+			}
 			break;
 		case 0x8409: /* VX855/VX875 */
 		case 0x8410: /* VX900 */
 			mmio_base = pci_read_long(dev, 0xbc) << 8;
+			if (mmio_base == 0x0) {
+				msg_pdbg ("MMIO not enabled!\n");
+				return ERROR_FATAL;
+			}
 			mmio_base_physmapped = physmap("VIA VX MMIO register", mmio_base, SPI_CNTL_LEN);
 			if (mmio_base_physmapped == ERROR_PTR)
 				return ERROR_FATAL;

-- 
To view, visit https://review.coreboot.org/22263
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293
Gerrit-Change-Number: 22263
Gerrit-PatchSet: 1
Gerrit-Owner: Lubomir Rintel <[e-mail]>