Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: Add unit test to run init/shutdown for enabled drivers ......................................................................
Patch Set 1:
(1 comment)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/004d3454_73f426ba PS1, Line 115: #endif /* UNIT_TEST_ENV */
I know it won't be as easy, but I'd much prefer such mocks in […]
I was thinking about separate compilation units for a while, how exactly to do this. Maybe you have some concrete ideas in mind? All that inb/outb functionality is in hwaccess.h. Can we have a hwaccess_unittest.h for test environment? Although it does not solve the question because for every driver needs its own mocking. For example mec1308 in this patch expects specific value from inb, not just any value.
-
Anastasia Klimchuk (Code Review)