Change in flashrom[master]: helpers: Add reverse_byte() and reverse_bytes()

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28086 )

Change subject: helpers: Add reverse_byte() and reverse_bytes()
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/28086/1/flash.h
File flash.h:

https://review.coreboot.org/#/c/28086/1/flash.h@299
PS1, Line 299: void reverse_bytes(uint8_t *dst, const uint8_t *src, size_t length);
Memory is returning. I think my argument was that we're changing
the order of bits not bytes. Ofc, we can't name both functions
`reverse_bits`... my current choice would be:

  uint8_t reverse_bits(uint8_t);
  void reverse_bits_copy(uint8_t *, const uint8_t *, size_t);

But I won't fight it, if you want to keep the current names.



-- 
To view, visit https://review.coreboot.org/28086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2e1e2856c835d22eed3b3a34bc0379773dd831
Gerrit-Change-Number: 28086
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Schink <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 15 Aug 2018 17:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes