[XS] Change in flashrom[main]: tests/selfcheck.c: Include the missing header lifecycle.h

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen.

Anastasia Klimchuk has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/83219?usp=email )

Change subject: tests/selfcheck.c: Include the missing header lifecycle.h
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Patchset:

PS1: 
I believe you that the issue is real, but I think the solution is not correct. We need to find the right solution.


PS1:
> as long as we need it, we should include it

We don't need lifecycle.h here :) Let's debug the issue properly.

I am super suspicious of this:
> error: type of ‘selfcheck_board_matches_table’ defaults to ‘int’ [-Werror=implicit-int]

First of all , which options did you use for compiling? CHROMIUM repository might have slightly different compiler options set up.
Also, was CONFIG_INTERNAL enabled?


Commit Message:

https://review.coreboot.org/c/flashrom/+/83219/comment/35a145f0_6dc67b75?usp... :
PS1, Line 9: selfcheck.c is using the macro SKIP_TEST, so we should include the
           : header lifecycle.h
SKIP_TEST is defined in `include/test.h` , which is already included.
`lifecycle.h` is not relevant to SKIP_TEST neither to selfcheck. If you look into lifecycle.h you can see it has functions for programmer lifecycle, this is why all programmer tests have it.

Here it is not needed.

I believe you that you see an error on your environment, but lifecycle.h is not the solution. We need to figure out why exactly the error is happening.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/83219?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ifc07ac66320712fdbf31504b9a980354c1883f40
Gerrit-Change-Number: 83219
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Hsuan Ting Chen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Hsuan Ting Chen <[e-mail]>
Gerrit-Attention: Hsuan-ting Chen <[e-mail]>
Gerrit-Comment-Date: Sat, 29 Jun 2024 09:23:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hsuan-ting Chen <[e-mail]>