[L] Change in flashrom[main]: erasure_layout: Fix get_flash_region bug

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Aarya, Alexander Goncharov, Nikolai Artemiev, Peter Marheine.

Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82393?usp=email )

Change subject: erasure_layout: Fix get_flash_region bug
......................................................................


Patch Set 14:

(1 comment)

File erasure_layout.c:

https://review.coreboot.org/c/flashrom/+/82393/comment/fecea642_135db866?usp... :
PS13, Line 368: for (unsigned int addr = region_start; addr <= region_end; addr += len) {
> I have changed tests, and looked into debugging messages, and now I have a piece of mind that the bu […]
> I made CB:82723 to illustrate, the issue repro on head

Now the question is, how urgent the issue is. The memory is erased correctly, but not in an optimal way.
Peter what do you think?

(also for this latest patchset, Jenkins is not adding a comment, but the results are here https://qa.coreboot.org/job/flashrom_gerrit/11678/console)



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/82393?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic5bf9d0f0e4a94c48d6f6e74e3cb9cccdc7adec9
Gerrit-Change-Number: 82393
Gerrit-PatchSet: 14
Gerrit-Owner: Peter Marheine <[e-mail]>
Gerrit-Reviewer: Aarya <[e-mail]>
Gerrit-Reviewer: Alexander Goncharov <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Aarya <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Attention: Alexander Goncharov <[e-mail]>
Gerrit-Comment-Date: Fri, 31 May 2024 11:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>