[XS] Change in flashrom[main]: erasure_layout: Fix init_eraseblock segmentation fault
Attention is currently required from: Aarya, DigitalDJ. Anastasia Klimchuk has posted comments on this change by DigitalDJ. ( https://review.coreboot.org/c/flashrom/+/84234?usp=email ) Change subject: erasure_layout: Fix init_eraseblock segmentation fault ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/84234/comment/350182da_6b6b268e?usp... : PS3, Line 9: Fix a segmentation fault that is caused by accessing an invalid "subedata" pointer on the last iteration of the init_eraseblock loop. Instead, short circuit the loop condition to check the sub block index first, and do not access the invalid pointer if it is the last sub block. Could you please wrap commit message to 72 chars, as in our dev guide, thanks! https://flashrom.org/dev_guide/development_guide.html#commit-message-1 -- To view, visit https://review.coreboot.org/c/flashrom/+/84234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I61bf0d93aa9f0b2b420b146be16fcd5124f0dc5d Gerrit-Change-Number: 84234 Gerrit-PatchSet: 3 Gerrit-Owner: DigitalDJ Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal@gmail.com> Gerrit-Attention: DigitalDJ Gerrit-Comment-Date: Fri, 06 Sep 2024 13:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
Anastasia Klimchuk (Code Review)