Change in flashrom[master]: layout: Add -i <region>[:<file>] support.

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 13: (3 comments) PS13 addresses a couple lingering issues from earlier patch sets. I also came up with a patch to try and implement the original intended behavior for '-w': https://review.coreboot.org/#/c/flashrom/+/23353/ It's a bit hacky though, though it does allow us to keep the policy decision in the CLI code. There might be a better way. https://review.coreboot.org/#/c/23021/5/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/5/flashrom.c@1484 PS5, Line 1484: const char *region_file = layout->entries[i].file; : : if (first_entry_encountered == 0) { : ms
Should be kept in do_write_buf_to_file() where the actual file handling […] Done
https://review.coreboot.org/#/c/23021/5/layout.c File layout.c: https://review.coreboot.org/#/c/23021/5/layout.c@217 PS5, Line 217: }
why? is it necessary? doesn't `file` point into `argv` of main()? No, I don't think it's necessary. It seems to be a remnant of https://mail.coreboot.org/pipermail/flashrom/2013-October/011729.html, but that may have been based on an even older version of layout.c from CrOS.
https://review.coreboot.org/#/c/23021/5/layout.c@285 PS5, Line 285: removed this as well since we don't need to allocate memory for layout.entries[i].file. -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 13 Gerrit-Owner: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Nicola Corna <nicola@corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 22 Jan 2018 08:20:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
participants (1)
-
David Hendricks (Code Review)