Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 )
Change subject: Fix -Wunused-parameter issues
Patch Set 5:
I personally think "(void)flash;" looks really ugly
It really does.
Though, I try not to judge it by asthetics but the potential
benefit of the warning. Does anybody recall or imagine bugs
that would be prevented by -Wunused-parameter?
In cases where the parameter can't be removed, adding the (void) cast is at least useful documentation since it signifies the author recognized this and didn't make a mistake by not using it.
Or maybe hide the ugliness behind a macro...
(please don't shoot me for suggesting that)
I think C2X will allow omitting the name of a parameter and just stating the type (which is currently allowed in C++ and silences this warning), so even though it's ugly now there may be less ugly options in the future.
To view, visit https://review.coreboot.org/c/flashrom/+/30410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Owner: Nico Huber email@example.com
Gerrit-Reviewer: Angel Pons firstname.lastname@example.org
Gerrit-Reviewer: Arthur Heymans email@example.com
Gerrit-Reviewer: David Hendricks firstname.lastname@example.org
Gerrit-Reviewer: Edward O'Callaghan email@example.com
Gerrit-Reviewer: Jacob Garber firstname.lastname@example.org
Gerrit-Reviewer: Nico Huber email@example.com
Gerrit-Reviewer: Richard Hughes firstname.lastname@example.org
Gerrit-Reviewer: Stefan T email@example.com
Gerrit-Reviewer: build bot (Jenkins) firstname.lastname@example.org
Gerrit-CC: Paul Menzel email@example.com
Gerrit-Comment-Date: Tue, 06 Aug 2019 19:33:11 +0000