[L] Change in flashrom[main]: erasure_layout: Fix get_flash_region bug

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Aarya, Alexander Goncharov, Nikolai Artemiev, Peter Marheine.

Anastasia Klimchuk has uploaded a new patch set (#14) to the change originally created by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82393?usp=email )

The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)


Change subject: erasure_layout: Fix get_flash_region bug
......................................................................

erasure_layout: Fix get_flash_region bug

When flash regions are protected, erase could incorrectly erase regions
which were meant to be protected by requesting the correct size but
using an erase opcode with coarser granularity than desired (for
instance using a 16-byte erase command while attempting to erase only 8
bytes).

This fixes that by exchanging the nesting of the loops over erase blocks
and flash regions.

Old:
 - Select erasefns
 - Loop over blocks to erase for each selected erasefn
  - Loop over programmer flash regions within erase block
    - Erase regions (may fail since selected erasefn will be
      too big if flash region is smaller than erase block)

New:
 - Loop over programmer flash regions within erase block
   - Select erasefns within programer flash region
     - Loop over blocks to erase for each selected erasefn
     - Erase regions

Eraser selection and erasing has also been factored out into a helper
function to manage nesting depth.

TEST=New test cases pass, whereas some of them fail without the changes
     to erasure_layout.c
BUG=https://ticket.coreboot.org/issues/525

Change-Id: Ic5bf9d0f0e4a94c48d6f6e74e3cb9cccdc7adec9
Co-authored-by: Nikolai Artemiev <[e-mail]>
Co-authored-by: Anastasia Klimchuk <[e-mail]>
Signed-off-by: Nikolai Artemiev <[e-mail]>
Signed-off-by: Anastasia Klimchuk <[e-mail]>
Signed-off-by: Peter Marheine <[e-mail]>
---
M erasure_layout.c
M tests/erase_func_algo.c
M tests/tests.c
M tests/tests.h
4 files changed, 495 insertions(+), 96 deletions(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/82393/14
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/82393?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic5bf9d0f0e4a94c48d6f6e74e3cb9cccdc7adec9
Gerrit-Change-Number: 82393
Gerrit-PatchSet: 14
Gerrit-Owner: Peter Marheine <[e-mail]>
Gerrit-Reviewer: Aarya <[e-mail]>
Gerrit-Reviewer: Alexander Goncharov <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Aarya <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Attention: Alexander Goncharov <[e-mail]>