David Hendricks has posted comments on this change. ( https://review.coreboot.org/20513 )
Change subject: 4BA: Basic support for 4-bytes addressing mode extensions ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Either way is fine with me. If you have time and can edit this patch, I'll be happy to re-review and ack. There might be style issues in the follow-up patches, so perhaps doing a single !fixup would be the easiest/quickest thing to do here.
https://review.coreboot.org/#/c/20513/1/spi4ba.c File spi4ba.c:
https://review.coreboot.org/#/c/20513/1/spi4ba.c@127 PS1, Line 127: + 1) - 1
I'd eventually like to switch to using dynamically allocated memory
That sounds good to me as well.
-
David Hendricks (Code Review)