[XS] Change in flashrom[main]: linux_mtd: fix build with clang >= 19
Attention is currently required from: Arnaud Ferraris. Maximilian Brune has posted comments on this change by Arnaud Ferraris. ( https://review.coreboot.org/c/flashrom/+/84856?usp=email ) Change subject: linux_mtd: fix build with clang >= 19 ...................................................................... Patch Set 2: (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/84856/comment/00e51fff_ab27b6e0?usp... : PS2, Line 52: char path[sizeof(LINUX_MTD_SYSFS_ROOT) + 32]; You have changed the size of the path variable. It doesn't look like to be a problem here, but a notable difference nonethless. nit: either keep the previous size or mention it in the commit msg. -- To view, visit https://review.coreboot.org/c/flashrom/+/84856?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If470a65702e9ae08e4303123a0014e53a1fee56e Gerrit-Change-Number: 84856 Gerrit-PatchSet: 2 Gerrit-Owner: Arnaud Ferraris <arnaud.ferraris@collabora.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: Arnaud Ferraris <arnaud.ferraris@collabora.com> Gerrit-Comment-Date: Mon, 28 Oct 2024 18:41:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
Maximilian Brune (Code Review)