[M] Change in flashrom[main]: Display progress for what is actually erased/written

Attention is currently required from: Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email ) Change subject: Display progress for what is actually erased/written ...................................................................... Patch Set 17: Code-Review+2 (2 comments) Patchset: PS16:
Just out of curiosity I ran the test case from here https://review.coreboot. […] Read also reaches 50% for the second command:
Found Winbond flash chip "W25Q128.V" (16384 kB, SPI) on dummy.
Reading old flash chip contents...
[READ: 100%]...done.
Updating flash chip contents...
[READ: 50%][ERASE: 50%][WRITE: 100%]...Erase/write done from 0 to ffffff
Verifying flash...
[READ: 100%]...VERIFIED.
Erasure is probably the result of selecting more fine-grained erasure functions in `erasure_layout.c`. Not sure about reads. File flashrom.c: https://review.coreboot.org/c/flashrom/+/84439/comment/a8f29ee5_d947e26b?usp... : PS13, Line 1270: // FIXME: round up to granularity?
Okay so I will close this (and the other one). […] Sure.
-- To view, visit https://review.coreboot.org/c/flashrom/+/84439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Gerrit-Change-Number: 84439 Gerrit-PatchSet: 17 Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Thu, 31 Oct 2024 14:44:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
participants (1)
-
Sergii Dmytruk (Code Review)