Change in flashrom[master]: chipset_enable.c: Mark Intel Z390 as DEP
Attention is currently required from: melvyn2. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58774 ) Change subject: chipset_enable.c: Mark Intel Z390 as DEP ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58774/comment/e0771009_10192c29 PS3, Line 9: me_cleaner Minor: Our guidelines state that commit message lines wrap at 72 characters [1]. `me_cleaner` goes past the limit, so it should go in a new line. [1]: https://flashrom.org/Development_Guidelines#Commit_message https://review.coreboot.org/c/flashrom/+/58774/comment/9611dc8c_d84dcd52 PS3, Line 12: melvyn2 As per our Sign-off procedure [1], I'm afraid you have to use your real name here. [1]: https://flashrom.org/Development_Guidelines#Sign-off_Procedure Patchset: PS3: Welcome! The change itself looks good, but the sign-off needs to be addressed. -- To view, visit https://review.coreboot.org/c/flashrom/+/58774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912 Gerrit-Change-Number: 58774 Gerrit-PatchSet: 3 Gerrit-Owner: melvyn2 <melvyn2@brcok.tk> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: melvyn2 <melvyn2@brcok.tk> Gerrit-Comment-Date: Mon, 01 Nov 2021 09:27:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
participants (1)
-
Angel Pons (Code Review)