Change in flashrom[master]: buspirate_spi: Add support for variable serial speeds

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23057 )

Change subject: buspirate_spi: Add support for variable serial speeds
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

I'll take it as is. You can still optimize that delay in a follow-up
if you want.

https://review.coreboot.org/#/c/23057/6/buspirate_spi.c
File buspirate_spi.c:

https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@473
PS6, Line 473: 			sleep(1);
> It's really just a safe value. […]
> Idk, if it's worth it depends pretty much on the optimal value. e.g.
> if it's <1ms, it's definitely worth it, if >500ms, rather not.

OTOH, if it's close to 1s, we might not be even safe yet. So it would
be be nice to know, even if we don't optimize it ;)



-- 
To view, visit https://review.coreboot.org/23057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf
Gerrit-Change-Number: 23057
Gerrit-PatchSet: 6
Gerrit-Owner: Shawn Anastasio <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Shawn Anastasio <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 26 Jan 2018 15:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes