[L] Change in flashrom[main]: Complete and fix progress feature implementation for all operations
Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/84102?usp=email ) Change subject: Complete and fix progress feature implementation for all operations ...................................................................... Patch Set 6: (3 comments) File cli_output.c: https://review.coreboot.org/c/flashrom/+/84102/comment/fd006211_ba7b831f?usp... : PS4, Line 119: 16 * FLASHROM_PROGRESS_NR
For 100% it will be 13 chars which I rounded to 16. `\b \b` is: […] Oh this is a backspace that is not deleting characters! Sorry I got so confused.
I made an attempt to introduce the flag. It is a bit sad that I added a global state, but it seems this is how cli_output currently works :\ To test , running the same commands as is in your commit message will backspace and print on the top. But when I added -VVV , I got lots of messages in between progress indicator %, so I could see in debugger that new line is printed instead of backspace. (the terminal explodes when you give -VVV to dummy, it prints every byte) File flashrom.c: https://review.coreboot.org/c/flashrom/+/84102/comment/39344173_d76e25fd?usp... : PS5, Line 1235: /* const size_t flash_size = flashctx->chip->total_size * 1024; */ : /* const size_t page_size = flashctx->chip->page_size; */
Sure. Done
https://review.coreboot.org/c/flashrom/+/84102/comment/5eeadbe0_4a7edd57?usp... : PS5, Line 1958: init_progress(flashctx, FLASHROM_PROGRESS_READ, flash_size); // WTF?
I think it was before addressing progress reporting on SPI reads, so adding this line caused progres […] Okay I removed the comment.
-- To view, visit https://review.coreboot.org/c/flashrom/+/84102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If1e40fc97f443c4f0c0501cef11cff1f3f84c051 Gerrit-Change-Number: 84102 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal@gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Comment-Date: Tue, 01 Oct 2024 13:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
participants (1)
-
Anastasia Klimchuk (Code Review)