Change in flashrom[master]: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call

Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 ) Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call ...................................................................... Patch Set 9: (3 comments) https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@7 PS8, Line 7: to save programming time
Omit this part from the commit summary Done
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@9 PS8, Line 9: Every ftdi_write_data() call is quite time consuming as the ftdi-chips seems to take always 2-3ms to respond.
Please split these lines so that they aren't longer than 72 characters Done
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@17 PS8, Line 17: https://ibb.co/0c1J25d
These links will stop working at some point. How do I better? Is there a better way to provide images? Just let me know.
-- To view, visit https://review.coreboot.org/c/flashrom/+/40477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a Gerrit-Change-Number: 40477 Gerrit-PatchSet: 9 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 26 May 2020 09:18:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Simon Buhrow (Code Review)