Change in flashrom[refs/meta/config]: Review access change
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/38321 ) Change subject: Review access change ...................................................................... Review access change Change-Id: I91f942850335487436433fc937627271870dcaa5 --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/38321/1 diff --git a/project.config b/project.config index a11f362..e3b7a6d 100644 --- a/project.config +++ b/project.config @@ -48,6 +48,8 @@ delete = group user/Nico Huber (Nico) delete = group user/Stefan T (stefanct) submit = group flashrom developers + label-Code-Review = -2..+2 group flashrom developers + label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push [project] -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: newchange
Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/38321 ) Change subject: Extend prviliges of "flashrom developers" group ...................................................................... Extend prviliges of "flashrom developers" group Allow all "flashrom developers" to give Code-Review -2/+2 and Verified -1/+1. Change-Id: I91f942850335487436433fc937627271870dcaa5 --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/38321/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: newpatchset
Hello Stefan T, David Hendricks, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/38321 to look at the new patch set (#3). Change subject: Extend privileges of "flashrom developers" group ...................................................................... Extend privileges of "flashrom developers" group Allow all "flashrom developers" to give Code-Review -2/+2 and Verified -1/+1 for code changes. Change-Id: I91f942850335487436433fc937627271870dcaa5 --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/38321/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38321 ) Change subject: Extend privileges of "flashrom developers" group ...................................................................... Patch Set 3: Any updates? I can't even give a +1, so I'll just say it out loud. -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Fri, 06 Mar 2020 18:33:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38321 ) Change subject: Extend privileges of "flashrom developers" group ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Mon, 09 Mar 2020 15:07:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38321 ) Change subject: Extend privileges of "flashrom developers" group ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 22 Mar 2020 18:39:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/38321 ) Change subject: Extend privileges of "flashrom developers" group ...................................................................... Extend privileges of "flashrom developers" group Allow all "flashrom developers" to give Code-Review -2/+2 and Verified -1/+1 for code changes. Change-Id: I91f942850335487436433fc937627271870dcaa5 Reviewed-on: https://review.coreboot.org/c/flashrom/+/38321 Reviewed-by: David Hendricks <david.hendricks@gmail.com> Tested-by: Nico Huber <nico.h@gmx.de> --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Nico Huber: Verified David Hendricks: Looks good to me, approved diff --git a/project.config b/project.config index a11f362..e3b7a6d 100644 --- a/project.config +++ b/project.config @@ -48,6 +48,8 @@ delete = group user/Nico Huber (Nico) delete = group user/Stefan T (stefanct) submit = group flashrom developers + label-Code-Review = -2..+2 group flashrom developers + label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push [project] -- To view, visit https://review.coreboot.org/c/flashrom/+/38321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I91f942850335487436433fc937627271870dcaa5 Gerrit-Change-Number: 38321 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (3)
-
Angel Pons (Code Review) -
David Hendricks (Code Review)
-
Nico Huber (Code Review)