[S] Change in flashrom[main]: flashchips.c: Add support for XM25RU256C

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Georg Gottleuber has posted comments on this change by Georg Gottleuber. ( https://review.coreboot.org/c/flashrom/+/82101?usp=email ) Change subject: flashchips.c: Add support for XM25RU256C ...................................................................... Patch Set 4: (2 comments) Patchset: PS3:
Is this for 4K sector? You can add it to the array of block_erasers, next to existing SPI_BLOCK_ERAS […] Yes it is also for 4KB sectors. This mode is similar to SPI_BLOCK_ERASE_20 but uses 32-bit address instead of 24-bit address. At the moment I have no access to a XM25RU256C chip. Therefore I leave it.
File flashchips.c: https://review.coreboot.org/c/flashrom/+/82101/comment/8254491f_411d5dd2?usp... : PS3, Line 22118: TEST_UNTESTED
This probably slipped from a previous version of the patch? You already changed tested status to `TE […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/82101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I431474a662304d09438e274706d3fc9cfbbe0bd6 Gerrit-Change-Number: 82101 Gerrit-PatchSet: 4 Gerrit-Owner: Georg Gottleuber <ggo@tuxedo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com> Gerrit-Comment-Date: Wed, 29 May 2024 09:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Georg Gottleuber <ggo@tuxedo.de>
participants (1)
-
Georg Gottleuber (Code Review)