Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33337
Change subject: manibuilder: Enable CONFIG_EVERYTHING=yes ......................................................................
manibuilder: Enable CONFIG_EVERYTHING=yes
Change-Id: I4651b55744d730956aa8fda8fdfccbbd68cdda19 Signed-off-by: Nico Huber nico.h@gmx.de --- M util/manibuilder/Makefile 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/33337/1
diff --git a/util/manibuilder/Makefile b/util/manibuilder/Makefile index b1e161c..9b87f45 100644 --- a/util/manibuilder/Makefile +++ b/util/manibuilder/Makefile @@ -4,6 +4,7 @@
CC := ccache cc MAKECMD := make +MAKEARGS := CONFIG_EVERYTHING=yes
spc := spc += @@ -50,7 +51,7 @@ djgpp:6.1.0: CC=ccache i586-pc-msdosdjgpp-gcc djgpp:6.1.0: STRIP=i586-pc-msdosdjgpp-strip djgpp:6.1.0: LIBS_BASE=../ -djgpp:6.1.0: TARGET=strip +djgpp:6.1.0: MAKEARGS+=strip $(ANITA_TAGS): MAKECMD=gmake $(ALL_TAGS): export QUIET_SETUP=$(QUIET_TEST) $(ALL_TAGS): %: %-check-build @@ -65,7 +66,7 @@ $(MAKECMD) clean && $(MAKECMD) -j$${CPUS:-1} CC='$(CC)' \ $(if $(STRIP),STRIP='$(STRIP)') \ $(if $(LIBS_BASE),LIBS_BASE='$(LIBS_BASE)') \ - $(TARGET)" \ + $(MAKEARGS)" \ $(if $(QUIET_TEST),>/dev/null 2>&1) || echo $*: $$?
$(addsuffix -shell,$(ALL_TAGS)): %-shell: %-check-build
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33337 )
Change subject: manibuilder: Enable CONFIG_EVERYTHING=yes ......................................................................
Patch Set 1: Code-Review+2
David Hendricks has uploaded a new patch set (#3) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/33337 )
Change subject: manibuilder: Enable CONFIG_EVERYTHING=yes ......................................................................
manibuilder: Enable CONFIG_EVERYTHING=yes
Change-Id: I4651b55744d730956aa8fda8fdfccbbd68cdda19 Signed-off-by: Nico Huber nico.h@gmx.de --- M util/manibuilder/Makefile 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/33337/3
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33337 )
Change subject: manibuilder: Enable CONFIG_EVERYTHING=yes ......................................................................
Patch Set 5: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/33337 )
Change subject: manibuilder: Enable CONFIG_EVERYTHING=yes ......................................................................
manibuilder: Enable CONFIG_EVERYTHING=yes
Change-Id: I4651b55744d730956aa8fda8fdfccbbd68cdda19 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/flashrom/+/33337 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: David Hendricks david.hendricks@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/manibuilder/Makefile 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/manibuilder/Makefile b/util/manibuilder/Makefile index 2313717..deff683 100644 --- a/util/manibuilder/Makefile +++ b/util/manibuilder/Makefile @@ -4,6 +4,7 @@
CC := ccache cc MAKECMD := make +MAKEARGS := CONFIG_EVERYTHING=yes
spc := spc := $(spc) $(spc) @@ -50,7 +51,7 @@ djgpp:6.1.0: CC=ccache i586-pc-msdosdjgpp-gcc djgpp:6.1.0: STRIP=i586-pc-msdosdjgpp-strip djgpp:6.1.0: LIBS_BASE=../ -djgpp:6.1.0: TARGET=strip +djgpp:6.1.0: MAKEARGS+=strip $(ANITA_TAGS): MAKECMD=gmake $(ALL_TAGS): export QUIET_SETUP=$(QUIET_TEST) $(ALL_TAGS): %: %-check-build @@ -65,7 +66,7 @@ $(MAKECMD) clean && $(MAKECMD) -j$${CPUS:-1} CC='$(CC)' \ $(if $(STRIP),STRIP='$(STRIP)') \ $(if $(LIBS_BASE),LIBS_BASE='$(LIBS_BASE)') \ - $(TARGET)" \ + $(MAKEARGS)" \ $(if $(QUIET_TEST),>/dev/null 2>&1) || echo $*: $$?
$(addsuffix -shell,$(ALL_TAGS)): %-shell: %-check-build
-
Angel Pons (Code Review) -
David Hendricks (Code Review)
-
Nico Huber (Code Review)