[XS] Change in flashrom[main]: Add more delay time for jlink power on feature to stabilize the LDO a...

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: attila-v.

Anastasia Klimchuk has posted comments on this change by attila-v. ( https://review.coreboot.org/c/flashrom/+/86085?usp=email )

Change subject: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors
......................................................................


Patch Set 2:

(1 comment)

File jlink_spi.c:

https://review.coreboot.org/c/flashrom/+/86085/comment/8663c328_5770a1b2?usp... :
PS2, Line 469: internal_sleep(100000);
Thank you for details! In this case, it can be another programmer param?
What I mean is, for example currently jlink_spi has spispeed, serial etc (https://flashrom.org/classic_cli_manpage.html#jlink-spi-programmer) and it can be another param like that.

Do you have interest to update the patch to implement new param? Another option if you not interested to write code, I think I can do it, but then I will need your help with few things. Again, that's only if you are interested.

You can tell me what you think! including, if you don't want to do anything at all :) 

Concretely, I had a look today, few things that I will need help

1) naming the param - I produced `delay_after_power_on` in my head, but it feels long :( 

2) info for manpage, I made this text, is it correct? or, any other suggestions
> optional param: delay in milliseconds which is typically needed after enabling target power. If not set, default value is 10. Larger values can be needed for LDO-s and decoupling capacitors. Valid values between 10 and 1000.

3) testing - you currently have the setup to test the non-default value?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/86085?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28
Gerrit-Change-Number: 86085
Gerrit-PatchSet: 2
Gerrit-Owner: attila-v
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: attila-v
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: attila-v
Gerrit-Comment-Date: Thu, 08 May 2025 13:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Comment-In-Reply-To: attila-v