Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no

List overview All Threads
Download

newer

older

[S] Change in...

[M] Change in flashrom[master]:...

Arthur Heymans (Code Review)

3 Nov 2020 3 Nov '20

6:17 a.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

flaschips.c: Fix building with CONFIG_DUMMY=no

With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is definition of probe_variable_size.

Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M flashchips.c 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/1

diff --git a/flashchips.c b/flashchips.c index 48efb85..1681f42 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19081,3 +19081,7 @@ };

const unsigned int flashchips_size = ARRAY_SIZE(flashchips); + +#if !CONFIG_DUMMY +int probe_variable_size(struct flashctx *flash) { return 0; }; +#endif

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Angel Pons (Code Review)

3 Nov 3 Nov

6:21 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/flashrom/+/47166/1/flashchips.c File flashchips.c:

https://review.coreboot.org/c/flashrom/+/47166/1/flashchips.c@19086 PS1, Line 19086: int probe_variable_size(struct flashctx *flash) { return 0; }; declaration is in chipdrivers.h, maybe place this definition there as static inline?

Angel Pons (Code Review)

6:24 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/47166/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/47166/1//COMMIT_MSG@9 PS1, Line 9: is : definition is *no* definition

Nikolai Artemiev (Code Review)

19 May 19 May

1:47 p.m.

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Nikolai Artemiev has uploaded a new patch set (#2) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

flaschips.c: Fix building with CONFIG_DUMMY=no

With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is definition of probe_variable_size.

BUG=none BRANCH=none TEST=CONFIG_DUMMY=0 make && CONFIG_DUMMY=1 make

Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Signed-off-by: Arthur Heymans arthur@aheymans.xyz Signed-off-by: Nikolai Artemiev nartemiev@google.com Co-authored-by: Nikolai Artemiev nartemiev@google.com --- M chipdrivers.h 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/2

Nikolai Artemiev (Code Review)

1:49 p.m.

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Nikolai Artemiev has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

flaschips.c: Fix building with CONFIG_DUMMY=no

With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is no definition of probe_variable_size.

BUG=none BRANCH=none TEST=CONFIG_DUMMY=0 make && CONFIG_DUMMY=1 make

Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Signed-off-by: Arthur Heymans arthur@aheymans.xyz Signed-off-by: Nikolai Artemiev nartemiev@google.com Co-authored-by: Nikolai Artemiev nartemiev@google.com --- M include/chipdrivers.h 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/3

Nikolai Artemiev (Code Review)

1:50 p.m.

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/47166/comment/3ee0683c_0ce1ec8c PS1, Line 9: is : definition

...

is *no* definition

Done

Patchset:

PS3: Saw this waiting around in my gerrit dashboard, decided to resolve comments.

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/47166/comment/8962e73a_c51d198d PS1, Line 19086: int probe_variable_size(struct flashctx *flash) { return 0; };

...

declaration is in chipdrivers. […]

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Thu, 19 May 2022 20:50:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Felix Singer (Code Review)

3:48 p.m.

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/flashrom/+/47166/comment/c44bc3fd_023486c9 PS3, Line 7: flaschips flas*h*chips.c

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Attention: Nikolai Artemiev nartemiev@google.com Gerrit-Comment-Date: Thu, 19 May 2022 22:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

6:22 p.m.

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3: Oh wait I have a fix https://review.coreboot.org/c/flashrom/+/64488 ! Please review my fix :)

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Anastasia Klimchuk aklm@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Attention: Nikolai Artemiev nartemiev@google.com Gerrit-Comment-Date: Fri, 20 May 2022 01:22:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

6:35 p.m.

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3: Code-Review-1

(1 comment)

Patchset:

PS3:

...

Oh wait I have a fix https://review.coreboot. […]

Just to be clear what I meant to say: I prefer CB:64488 instead of this patch, because I prefer to fix the issue in a proper way. This patch looks like a workaround and not a fix. I hope you won't get upset of -1 !

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Attention: Nikolai Artemiev nartemiev@google.com Gerrit-Comment-Date: Fri, 20 May 2022 01:35:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org Gerrit-MessageType: comment

Felix Singer (Code Review)

6:59 p.m.

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3: -Code-Review

(1 comment)

Patchset:

PS3:

...

Just to be clear what I meant to say: I prefer CB:64488 instead of this patch, because I prefer to f […]

Awesome! Of course not 😊 Removing my +2.

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org Gerrit-Attention: Nikolai Artemiev nartemiev@google.com Gerrit-Comment-Date: Fri, 20 May 2022 01:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org Gerrit-MessageType: comment

Nikolai Artemiev (Code Review)

11:24 p.m.

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3: Code-Review-1

(1 comment)

Patchset:

PS3:

...

Awesome! Of course not 😊 Removing my +2.

+1, we should use CB:64488 instead

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org Gerrit-Comment-Date: Fri, 20 May 2022 06:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

21 Apr 21 Apr

3:28 a.m.

New subject: [S] Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:

...

Hello Arthur! Building without dummy got fixed in CB:64488 and the fix is merged. […]

Arthur I think I will abandon the patch , I have a button now. Original issue fixed in CB:64488 and it's better to abandon to avoid confusion. Hope you are fine with this !

-- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz Gerrit-Attention: Nikolai Artemiev nartemiev@google.com Gerrit-Comment-Date: Fri, 21 Apr 2023 10:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

3:29 a.m.

New subject: [S] Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ......................................................................

Abandoned

fixed in CB:64488

540

days inactive

1439

days old

flashrom-gerrit@flashrom.org

12 comments

5 participants

tags (0)

participants (5)

Anastasia Klimchuk (Code Review)
Angel Pons (Code Review)
Arthur Heymans (Code Review)
Felix Singer (Code Review)
Nikolai Artemiev (Code Review)