David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/42742 )
Change subject: tree: Remove unneeded semicolons after loops ......................................................................
tree: Remove unneeded semicolons after loops
Trivial cleanup
Change-Id: Id93a019a39b765c70b1a4eaeb25d9b582c3e4141 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M cbtable.c M usbblaster_spi.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/42742/1
diff --git a/cbtable.c b/cbtable.c index e566840..6185f12 100644 --- a/cbtable.c +++ b/cbtable.c @@ -205,7 +205,7 @@ msg_pdbg("Found coreboot table at 0x%08lx.\n", addr); return head;
- }; + }
return NULL; } diff --git a/usbblaster_spi.c b/usbblaster_spi.c index 46de86c..58a8a0e 100644 --- a/usbblaster_spi.c +++ b/usbblaster_spi.c @@ -160,7 +160,7 @@ return -1; } n_read -= payload_size; - }; + }
n_read = readcnt; while (n_read) {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42742 )
Change subject: tree: Remove unneeded semicolons after loops ......................................................................
Patch Set 1: Code-Review+2
*screams internally*
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/42742
to look at the new patch set (#2).
Change subject: tree: Remove unneeded semicolons after loops ......................................................................
tree: Remove unneeded semicolons after loops
Trivial cleanup
Change-Id: Id93a019a39b765c70b1a4eaeb25d9b582c3e4141 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M cbtable.c M usbblaster_spi.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/42742/2
David Hendricks has submitted this change. ( https://review.coreboot.org/c/flashrom/+/42742 )
Change subject: tree: Remove unneeded semicolons after loops ......................................................................
tree: Remove unneeded semicolons after loops
Trivial cleanup
Change-Id: Id93a019a39b765c70b1a4eaeb25d9b582c3e4141 Signed-off-by: David Hendricks david.hendricks@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/42742 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M cbtable.c M usbblaster_spi.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/cbtable.c b/cbtable.c index e566840..6185f12 100644 --- a/cbtable.c +++ b/cbtable.c @@ -205,7 +205,7 @@ msg_pdbg("Found coreboot table at 0x%08lx.\n", addr); return head;
- }; + }
return NULL; } diff --git a/usbblaster_spi.c b/usbblaster_spi.c index 46de86c..58a8a0e 100644 --- a/usbblaster_spi.c +++ b/usbblaster_spi.c @@ -160,7 +160,7 @@ return -1; } n_read -= payload_size; - }; + }
n_read = readcnt; while (n_read) {
-
Angel Pons (Code Review) -
David Hendricks (Code Review)