Change in flashrom[master]: buspirate_spi.c: Separate shutdown from failed init cleanup

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52877 )

Change subject: buspirate_spi.c: Separate shutdown from failed init cleanup
......................................................................


Patch Set 1:

(1 comment)

File buspirate_spi.c:

https://review.coreboot.org/c/flashrom/+/52877/comment/9ef3d665_9008d396 
PS1, Line 672: 	if (register_shutdown(buspirate_spi_shutdown, NULL) != 0) {
             : 		ret = 1;
             : 		goto init_err_cleanup_exit;
             : 	}
After moving register_shutdown below this has the same situation as CB:52773 , specifically if register_shutdown fails than full cleanup is performed. I use the same approach as we agreed on CB:52773



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04d57e2552d23a1a4a906c68539f0ccefc13e8a0
Gerrit-Change-Number: 52877
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Miklós Márton <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Tue, 04 May 2021 04:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment