Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33837
Change subject: flashchips.c: Make comment placement consistent ......................................................................
flashchips.c: Make comment placement consistent
For consistency, move a comment about an entry from inside the open brace to outside it.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie9a745b7e7dc752cfd6fc14ebeb04754179893c6 --- M flashchips.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/33837/1
diff --git a/flashchips.c b/flashchips.c index 8ea7043..f35965f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16578,7 +16578,8 @@ .read = read_memmapped, },
- {/* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ + /* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ + { .vendor = "Winbond", .name = "W29C010(M)/W29C011A/W29EE011/W29EE012", .bustype = BUS_PARALLEL,
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33837 )
Change subject: flashchips.c: Make comment placement consistent ......................................................................
Patch Set 5: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33837 )
Change subject: flashchips.c: Make comment placement consistent ......................................................................
Patch Set 5: Code-Review+2
Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33837
to look at the new patch set (#7).
Change subject: flashchips.c: Make comment placement consistent ......................................................................
flashchips.c: Make comment placement consistent
For consistency, move a comment about an entry from inside the open brace to outside it.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie9a745b7e7dc752cfd6fc14ebeb04754179893c6 --- M flashchips.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/33837/7
Edward O'Callaghan has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33837 )
Change subject: flashchips.c: Make comment placement consistent ......................................................................
flashchips.c: Make comment placement consistent
For consistency, move a comment about an entry from inside the open brace to outside it.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie9a745b7e7dc752cfd6fc14ebeb04754179893c6 Reviewed-on: https://review.coreboot.org/c/flashrom/+/33837 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index eaf04a8..246f139 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16607,7 +16607,8 @@ .read = read_memmapped, },
- {/* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ + /* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ + { .vendor = "Winbond", .name = "W29C010(M)/W29C011A/W29EE011/W29EE012", .bustype = BUS_PARALLEL,
-
Alan Green (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)