Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag - flashrom-gerrit

23 Nov 2017


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/22421 )
Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/22421/5/spi25.c
File spi25.c:
https://review.coreboot.org/#/c/22421/5/spi25.c@380
PS5, Line 380: 				 "Please report a bug at flashrom@flashrom.org\n");
...
Not a bug, I forgot about the block erasers (again)... or we could
How so? If you're referring to chip erase commands, those are handled using spi_simple_write_cmd() which doesn't call this function, so we should be good there at least.
-- 
To view, visit https://review.coreboot.org/22421
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c
Gerrit-Change-Number: 22421
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Nov 2017 06:23:20 +0000
Gerrit-HasComments: Yes