Change in flashrom[master]: [v4, 3/6] ENE EDI - add dummy read to ensure proper detection of ENE c...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23260 )

Change subject: [v4,3/6] ENE EDI - add dummy read to ensure proper detection of ENE chips
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/23260/1/edi.c
File edi.c:

https://review.coreboot.org/#/c/23260/1/edi.c@500
PS1, Line 500: 	edi_detect(flash);
> Yes, edi_detect is a function that includes probing

I don't see that. I only see a dummy read.



-- 
To view, visit https://review.coreboot.org/23260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9
Gerrit-Change-Number: 23260
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 02 Feb 2018 22:08:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No