Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23203 )

Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................


Patch Set 19:

(2 comments)

https://review.coreboot.org/#/c/23203/19/libflashrom.c
File libflashrom.c:

https://review.coreboot.org/#/c/23203/19/libflashrom.c@468
PS19, Line 468: (offset != 0)
means you check offset == 0 quite often if rom_offset is 0, could this not be checked once?


https://review.coreboot.org/#/c/23203/19/libflashrom.c@473
PS19, Line 473: break
Since this does not bail out on the stride loop we might as well use continue instead of break? if we continue this covers for instance Intel targets with locked regions.



-- 
To view, visit https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 19
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-Comment-Date: Wed, 08 Aug 2018 19:15:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No