Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56501 )
Change subject: tests: Add tests to erase a chip ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
The newest test that I have added uses real spi_send_command, however some previous tests are mocking the same function. Means, we have to have two tests executables where one of executables uses real spi_send_command and second one wraps spi_send_command.
Not sure if you don't know or if you tried and it turned out to be the worse solution: with `--wrap` you can literally wrap the original function. It should be available as __real_spi_send_command(). So with a little abstraction we could have a __wrap_spi_send_command() that would do the checks that it currently does and optionally calls the real spi_send_command().