Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62324 )
Change subject: tests/chips.c: Mock out open() for lock file ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62324/comment/f30a75d4_fa63767f PS3, Line 7: out
You can remove "out". Just "Mock open() for all chip tests". […]
Ack
Patchset:
PS6: Squashed into CB:62320
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/62324/comment/6a1f7efd_9fc4626b PS3, Line 212: data
Similarly as in previous patch, this can be `erase_chip_io_state` and same for the rest of the patch […]
Ack
https://review.coreboot.org/c/flashrom/+/62324/comment/9fc819ad_41fa69da PS3, Line 213: "/run/lock/flashrom_lock"
If this is exactly identical path for all the chip tests, can be a macro in this file?
Done
https://review.coreboot.org/c/flashrom/+/62324/comment/eef71adf_706f71f8 PS3, Line 222: io_mock_register(&chip_io);
You need to do `io_mock_register(NULL);` at the end of test, like verify tests do.
Done
-
Daniel Campello (Code Review)