[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83854/comment/3c6d1f6b_d175bd75?usp... : PS5, Line 10: : The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). : : TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected.
Just one last thing: if you could wrap commit message by max width 72 chars, as we have by the style […] Sorry, my laziness came out and I edited it in gerrit UI 😊 Corrected
-- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 8 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel@3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas@3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec@3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec@3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel@3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:56:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
participants (1)
-
Michał Żygowski (Code Review)