Nico Huber has posted comments on this change. (
https://review.coreboot.org/29306 )
Change subject: flashchips: Add IS25LP256 and IS25WP256
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/29306/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/29306/1/flashchips.c@7387
PS1, Line 7387: /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */
doesn't add any information
https://review.coreboot.org/#/c/29306/1/flashchips.c@7399
PS1, Line 7399: .block_erase = spi_block_erase_20,
Also aliased as d7. I wouldn't mind if you don't want to add it.
But a comment would be nice.
--
To view, visit
https://review.coreboot.org/29306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf7a224abcde5f7935d9ef88309f78207de60a7a
Gerrit-Change-Number: 29306
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 20:57:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes