Change in flashrom[master]: [WIP]dediprog: Implement 4-byte-address support

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/28804 )

Change subject: [WIP]dediprog: Implement 4-byte-address support
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

I was able to test this and it works with one small change (see comments).

I used an SF600 with firmware 7.2.21, with W25Q256JVFM and MX25L25735FMI and wrote to 1MB ranges in the lower and upper halves of the chip.

https://review.coreboot.org/#/c/28804/1/dediprog.c
File dediprog.c:

https://review.coreboot.org/#/c/28804/1/dediprog.c@399
PS1, Line 399: data_packet[3] = WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12
For some reason I cannot explain, this needs to be WRITE_MODE_4B_ADDR_256B_PAGE_PGM. That is the only way I have been able to successfully write using native 4BA commands.

I am not sure what WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12 is supposed to do...