Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35089 )
Change subject: flashchips: Add GD25Q127C name to the GD25Q128C entry ......................................................................
flashchips: Add GD25Q127C name to the GD25Q128C entry
Renamed GigaDevice GD25Q128 to GD25Q127C/GD25Q128.
According to downstream (ChromiumOS) change 4216ba3d0fbd1804a71002b9c17e0b04029a03f1 "flashchips: Add GD25Q127C name to the GD25Q128C entry", the 127C chip is replacement for the 128C chip. I have confirmed that 127C is newer and that 128C does not appear to be documented on Gigadevice's website or available from Digikey.
TEST=Ran flashrom -L
Signed-off-by: Alan Green avg@google.com Change-Id: I3366e5904eff2443fda90552f7f5e31a8785d8b3 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/35089/1
diff --git a/flashchips.c b/flashchips.c index 9b686c1..1c67887 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6158,7 +6158,7 @@
{ .vendor = "GigaDevice", - .name = "GD25Q128C", + .name = "GD25Q127C/GD25Q128C", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25Q128,
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35089 )
Change subject: flashchips: Add GD25Q127C name to the GD25Q128C entry ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35089 )
Change subject: flashchips: Add GD25Q127C name to the GD25Q128C entry ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35089 )
Change subject: flashchips: Add GD25Q127C name to the GD25Q128C entry ......................................................................
flashchips: Add GD25Q127C name to the GD25Q128C entry
Renamed GigaDevice GD25Q128 to GD25Q127C/GD25Q128.
According to downstream (ChromiumOS) change 4216ba3d0fbd1804a71002b9c17e0b04029a03f1 "flashchips: Add GD25Q127C name to the GD25Q128C entry", the 127C chip is replacement for the 128C chip. I have confirmed that 127C is newer and that 128C does not appear to be documented on Gigadevice's website or available from Digikey.
TEST=Ran flashrom -L
Signed-off-by: Alan Green avg@google.com Change-Id: I3366e5904eff2443fda90552f7f5e31a8785d8b3 Reviewed-on: https://review.coreboot.org/c/flashrom/+/35089 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index 9b686c1..1c67887 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6158,7 +6158,7 @@
{ .vendor = "GigaDevice", - .name = "GD25Q128C", + .name = "GD25Q127C/GD25Q128C", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25Q128,
-
Alan Green (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)