Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40857 )
Change subject: chipset_enable.c: Spell `BIOS` in uppercase ......................................................................
chipset_enable.c: Spell `BIOS` in uppercase
Change-Id: Ib66547b2b5d77658ab1925e4ad3acfe44e14843c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/40857/1
diff --git a/chipset_enable.c b/chipset_enable.c index 783bb94..632679c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -354,7 +354,7 @@ msg_pwarn("Warning: BIOS region SMM protection is enabled!\n");
if (new != wanted) - msg_pwarn("Warning: Setting Bios Control at 0x%x from 0x%02x to 0x%02x failed.\n" + msg_pwarn("Warning: Setting BIOS Control at 0x%x from 0x%02x to 0x%02x failed.\n" "New value is 0x%02x.\n", bios_cntl, old, wanted, new);
/* Return an error if we could not set the write enable only. */
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40857 )
Change subject: chipset_enable.c: Spell `BIOS` in uppercase ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40857 )
Change subject: chipset_enable.c: Spell `BIOS` in uppercase ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Marcello Sylvester Bauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/40857
to look at the new patch set (#2).
Change subject: chipset_enable.c: Spell `BIOS` in uppercase ......................................................................
chipset_enable.c: Spell `BIOS` in uppercase
Intel document #336067 uses `BIOS Control` to refer to this register.
Change-Id: Ib66547b2b5d77658ab1925e4ad3acfe44e14843c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/40857/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40857 )
Change subject: chipset_enable.c: Spell `BIOS` in uppercase ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40857 )
Change subject: chipset_enable.c: Spell `BIOS` in uppercase ......................................................................
chipset_enable.c: Spell `BIOS` in uppercase
Intel document #336067 uses `BIOS Control` to refer to this register.
Change-Id: Ib66547b2b5d77658ab1925e4ad3acfe44e14843c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/40857 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Marcello Sylvester Bauer sylv@sylv.io Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Marcello Sylvester Bauer: Looks good to me, but someone else must approve
diff --git a/chipset_enable.c b/chipset_enable.c index 783bb94..632679c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -354,7 +354,7 @@ msg_pwarn("Warning: BIOS region SMM protection is enabled!\n");
if (new != wanted) - msg_pwarn("Warning: Setting Bios Control at 0x%x from 0x%02x to 0x%02x failed.\n" + msg_pwarn("Warning: Setting BIOS Control at 0x%x from 0x%02x to 0x%02x failed.\n" "New value is 0x%02x.\n", bios_cntl, old, wanted, new);
/* Return an error if we could not set the write enable only. */
-
Angel Pons (Code Review) -
Marcello Sylvester Bauer (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)