Joshua Wise has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/44921 )
Change subject: chipset_enable.c: Add PCI ID for Comet Lake. ......................................................................
chipset_enable.c: Add PCI ID for Comet Lake.
Change-Id: Ic6eec4a650155810dc8430bec5b4f5d3091cf37f --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/44921/1
diff --git a/chipset_enable.c b/chipset_enable.c index 5fc222b..dbb4f7c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2068,6 +2068,7 @@ {0x8086, 0xa30d, B_S, NT, "Intel", "HM370", enable_flash_pch300}, {0x8086, 0xa30e, B_S, DEP, "Intel", "CM246", enable_flash_pch300}, {0x8086, 0x3482, B_S, DEP, "Intel", "Ice Lake U Premium", enable_flash_pch300}, + {0x8086, 0x02a4, B_S, NT, "Intel", "Comet Lake", enable_flash_pch300}, #endif {0}, };
Joshua Wise has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/44921 )
Change subject: chipset_enable.c: Add PCI ID for Comet Lake. ......................................................................
chipset_enable.c: Add PCI ID for Comet Lake.
Signed-off-by: Joshua Wise joshua@joshuawise.com Change-Id: Ic6eec4a650155810dc8430bec5b4f5d3091cf37f --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/44921/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44921 )
Change subject: chipset_enable.c: Add PCI ID for Comet Lake. ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/44921/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44921/2//COMMIT_MSG@7 PS2, Line 7: chipset_enable.c: Add PCI ID for Comet Lake. Please remove the dot/period at the end of the git commit message summary.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44921 )
Change subject: chipset_enable.c: Add PCI ID for Comet Lake. ......................................................................
Patch Set 2:
I've added this PCI ID to 44420
Joshua Wise has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44921 )
Change subject: chipset_enable.c: Add PCI ID for Comet Lake. ......................................................................
Patch Set 2: Code-Review-1
Patch Set 2:
I've added this PCI ID to 44420
Thanks. Abandoning this because 44420 supersedes this.
Joshua Wise has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/44921 )
Change subject: chipset_enable.c: Add PCI ID for Comet Lake. ......................................................................
Abandoned
Superseded by 44420.
-
Joshua Wise (Code Review) -
Matt DeVillier (Code Review)
-
Paul Menzel (Code Review)