27 Jun
2019
27 Jun
'19
8:50 a.m.
Alan Green has uploaded this change for review. (
https://review.coreboot.org/c/flashrom/+/33829
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
flashchips.c: ATMEL->Atmel for consistency
Replace the single instance where a vendor name was spelled
inconsistently.
Signed-off-by: Alan Green <avg(a)google.com>
Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
---
M flashchips.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/33829/1
diff --git a/flashchips.c b/flashchips.c
index 644479e..88648ad 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -2325,7 +2325,7 @@
},
{
- .vendor = "ATMEL",
+ .vendor = "Atmel",
.name = "AT25SL128A",
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-MessageType: newchange
27 Jun
27 Jun
9:17 a.m.
Angel Pons has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/33829 )
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 07:17:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
28 Jun
28 Jun
1:42 a.m.
Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33829
to look at the new patch set (#2).
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
flashchips.c: ATMEL->Atmel for consistency
Replace the single instance where a vendor name was spelled
inconsistently.
Signed-off-by: Alan Green <avg(a)google.com>
Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
---
M flashchips.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/33829/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
2:18 a.m.
Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33829
to look at the new patch set (#3).
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
flashchips.c: ATMEL->Atmel for consistency
Replace the single instance where a vendor name was spelled
inconsistently.
Signed-off-by: Alan Green <avg(a)google.com>
Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
---
M flashchips.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/33829/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
1 Jul
1 Jul
3:16 a.m.
Hello HAOUAS Elyes, Edward O'Callaghan, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33829
to look at the new patch set (#5).
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
flashchips.c: ATMEL->Atmel for consistency
Replace the single instance where a vendor name was spelled
inconsistently.
Signed-off-by: Alan Green <avg(a)google.com>
Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
---
M flashchips.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/33829/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
2 Jul
2 Jul
5:48 a.m.
Edward O'Callaghan has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/33829 )
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 02 Jul 2019 03:48:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
11:46 a.m.
Nico Huber has submitted this change and it was merged. (
https://review.coreboot.org/c/flashrom/+/33829 )
Change subject: flashchips.c: ATMEL->Atmel for consistency
......................................................................
flashchips.c: ATMEL->Atmel for consistency
Replace the single instance where a vendor name was spelled
inconsistently.
Signed-off-by: Alan Green <avg(a)google.com>
Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33829
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M flashchips.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c
index f7ee829..8bbf15b 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -2325,7 +2325,7 @@
},
{
- .vendor = "ATMEL",
+ .vendor = "Atmel",
.name = "AT25SL128A",
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
--
To view, visit https://review.coreboot.org/c/flashrom/+/33829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6478bc29f640f789f3b35e7b4816133f4a0d292e
Gerrit-Change-Number: 33829
Gerrit-PatchSet: 6
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: merged
511
days inactive
516
days old
6 comments
4 participants
participants (4)
-
Alan Green (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)
-
Nico Huber (Code Review)